compatibility checking #1699
Merged
compatibility checking #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-compat
branch
from
1a94bd5 to
12296ea
Compare
This reverts commit 12296ea.
richardm-stripe
commented
Dec 1, 2023
anniel-stripe
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs
japi-compliance-checkerin CI.The new "compat" CI job will fail if you've introduced any breaking changes (it shouldn't be required to merge, but it is a nice data point to have).
Also, if you go to the Action "workflow", a
.zipfile with the compatibility report inside will be available at the bottom under "Artifacts". See the second to last commit on this branch.